Skip to content

Do not find protobuf for python#535

Merged
amcadmus merged 1 commit into
deepmodeling:masterfrom
njzjz:revert_find_protobuf
Apr 20, 2021
Merged

Do not find protobuf for python#535
amcadmus merged 1 commit into
deepmodeling:masterfrom
njzjz:revert_find_protobuf

Conversation

@njzjz

@njzjz njzjz commented Apr 19, 2021

Copy link
Copy Markdown
Member

In conda-forge's recent released tensorflow, protobuf is external
from tensorflow and not inside the tensorflow directory.

In conda-forge's recent released tensorflow, protobuf is external
from tensorflow and not inside the tensorflow directory.
@njzjz

njzjz commented Apr 19, 2021

Copy link
Copy Markdown
Member Author

The error was

2021-04-19T23:17:03.5191120Z CMake Error at cmake/Findtensorflow.cmake:45 (message):
2021-04-19T23:17:03.5195290Z Not found 'tensorflow/core/public/session.h' directory in path
2021-04-19T23:17:03.5202627Z '/home/conda/feedstock_root/build_artifacts/deepmd-kit_1618873830865/h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.8/site-packages/tensorflow;/home/conda/feedstock_root/build_artifacts/deepmd-kit_1618873830865/h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.8/site-packages/tensorflow/../tensorflow_core;/home/conda/feedstock_root/build_artifacts/deepmd-kit_1618873830865/h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.8/site-packages/tensorflow;/home/conda/feedstock_root/build_artifacts/deepmd-kit_1618873830865/h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.8/site-packages/tensorflow/../tensorflow_core;/usr/;/usr/local/'
2021-04-19T23:17:03.5208133Z You can manually set the tensorflow install path by -DTENSORFLOW_ROOT
2021-04-19T23:17:03.5212224Z Call Stack (most recent call first):
2021-04-19T23:17:03.5216800Z CMakeLists.txt:50 (find_package)

This PR should also be cherry-picked to r1.2 branch.

@amcadmus

Copy link
Copy Markdown
Member

Does this change compatible with older versions of TF?

@njzjz

njzjz commented Apr 20, 2021

Copy link
Copy Markdown
Member Author

Does this change compatible with older versions of TF?

This has nothing to do with TF versions. See https://github.com/conda-forge/tensorflow-feedstock/blob/40db5f43756877bea9e0dd2685cd5683b6527904/recipe/build.sh#L30, and here protobuf will be an external library, and will not built by bazel or packaged into the TF package. (It's used to reduce the build time)

@njzjz

njzjz commented Apr 20, 2021

Copy link
Copy Markdown
Member Author

In fact, I think we don't need libprotobuf headers to build python package, is it correct?

@amcadmus

Copy link
Copy Markdown
Member

In fact, I think we don't need libprotobuf headers to build python package, is it correct?

You are right

@amcadmus amcadmus merged commit 4cd609d into deepmodeling:master Apr 20, 2021
@njzjz njzjz deleted the revert_find_protobuf branch May 14, 2021 02:11
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants